-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gallery example to show usage of dcw parameter in Figure.coast #2428
Conversation
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not marked ready for review, but here are some changes I thought would be good.
Co-authored-by: Will Schlitzer <[email protected]>
@michaelgrund Is this ready for review, or are you still working on it? |
Yes it is, thanks for your comments and improvements @willschlitzer. |
/format |
For unknown reasons, all the inline comments disappear in the built page (https://pygmt-dev--2428.org.readthedocs.build/en/2428/gallery/maps/country_polygons.html). |
Co-authored-by: Yvonne Fröhlich <[email protected]>
Strange, also the title changes are not considered. |
Hm. Did someone change something to fix this? If not, that's really strange, because I face none of these issues. As title of this gallery example I see "Highlight country and continent polygons" (not "Highlight country polygons") and the inline examples are displayed in the API references. |
In my case it depends on the device. On my smartphone everything looks fine, |
Yes, now it looks good. |
Added this use-case. |
Co-authored-by: Yvonne Fröhlich <[email protected]>
/format |
Co-authored-by: Yvonne Fröhlich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion on the projection for Europe, otherwise ready for final review!
Added also "state" to the title since now we're showing 3 different use-cases.
Description of proposed changes
This PR adds a gallery example to show the basic usage of the
dcw
parameter.Preview: https://pygmt-dev--2428.org.readthedocs.build/en/2428/gallery/maps/country_polygons.html
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version